Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-run the benchmarks #1586

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Re-run the benchmarks #1586

merged 1 commit into from
Sep 15, 2023

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented Sep 14, 2023

Details on the issue fix or feature implementation

Just re-running the benchmarks.

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label Sep 14, 2023
@martintmk martintmk added this to the v8.0.0 milestone Sep 14, 2023
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (8d47508) 83.99% compared to head (3b7708b) 83.99%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1586   +/-   ##
=======================================
  Coverage   83.99%   83.99%           
=======================================
  Files         280      280           
  Lines        6548     6548           
  Branches     1020     1020           
=======================================
  Hits         5500     5500           
  Misses        839      839           
  Partials      209      209           
Flag Coverage Δ
linux 83.99% <ø> (ø)
macos 83.99% <ø> (ø)
windows 83.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martintmk martintmk merged commit 49726ab into main Sep 15, 2023
@martintmk martintmk deleted the mtomka/update-benchmarks branch September 15, 2023 04:53
adamnova pushed a commit to adamnova/Polly that referenced this pull request Sep 15, 2023
@martincostello
Copy link
Member

Weird how in some of the benchmarks v7 got slower and v8 got faster 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants