Remove Moq #1472
Merged
Remove Moq #1472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove Moq and replace with NSubstitute. Resolves App-vNext#1470.
martincostello
added
CI/build
dependencies
Codecov Report
@@ Coverage Diff @@
## main #1472 +/- ##
=======================================
Coverage 83.88% 83.88%
=======================================
Files 275 275
Lines 6492 6492
Branches 1015 1015
=======================================
Hits 5446 5446
Misses 837 837
Partials 209 209
Flags with carried forward coverage won't be shown. Click here to find out more. |
martintmk
reviewed
Aug 9, 2023
| var result = new ValueTask<RateLimitLease>(_lease); | ||
| _limiter | ||
| .GetType() | ||
| .GetMethod("AcquireAsyncCore", BindingFlags.NonPublic | BindingFlags.Instance)! |
There was a problem hiding this comment.
:(
Was not nice even before though ...
There was a problem hiding this comment.
Yeah, protected mocking always looks ugly.
martintmk
approved these changes
Aug 9, 2023
|
LGTM, the syntax is surprisingly nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes Moq and replaces it with NSubstitute.
May need some tweaks to mutations and/or coverage as the previous strict mock behaviour isn't available to use.Resolves #1470.