Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop the Extensions from Polly.Extensions namespace #1469

Merged
merged 5 commits into from
Aug 9, 2023

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented Aug 9, 2023

Details on the issue fix or feature implementation

Having Extensions in the namespace feels unnecessary. New namespaces:

  • Polly.Extensions.Telemetry -> Polly.Telemetry
  • Polly.Extensions.DependencyInjection -> Polly.DependencyInjection

Additionally, I have also moved Polly.Utils.LegacySupport to Polly.LegacySupport so the Utils namespace is not exposed.

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label Aug 9, 2023
@martintmk martintmk added this to the v8.0.0 milestone Aug 9, 2023
@martintmk martintmk marked this pull request as draft August 9, 2023 07:19
@martintmk martintmk changed the title Move ConfigureBuilderContextExtensions under Polly.Registry namespace Drop the Extensions from Polly.Extensions namespace Aug 9, 2023
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #1469 (9db53ef) into main (3d8d6f4) will decrease coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1469      +/-   ##
==========================================
- Coverage   83.89%   83.88%   -0.01%     
==========================================
  Files         275      275              
  Lines        6495     6492       -3     
  Branches     1015     1015              
==========================================
- Hits         5449     5446       -3     
  Misses        837      837              
  Partials      209      209              
Flag Coverage Δ
linux ?
macos ?
windows 83.88% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...Core/CircuitBreaker/CircuitBreakerManualControl.cs 100.00% <ø> (ø)
...CircuitBreaker/CircuitBreakerResilienceStrategy.cs 100.00% <ø> (ø)
src/Polly.Core/LegacySupport.cs 100.00% <ø> (ø)
src/Polly.Core/ResilienceStrategyT.Async.cs 100.00% <ø> (ø)
src/Polly.Core/Retry/RetryResilienceStrategy.cs 100.00% <ø> (ø)
...rc/Polly.Core/Utils/CompositeResilienceStrategy.cs 100.00% <ø> (ø)
src/Polly.Core/Utils/TaskHelper.cs 100.00% <ø> (ø)
...ependencyInjection/AddResilienceStrategyContext.cs 100.00% <ø> (ø)
...tion/ConfigureResilienceStrategyRegistryOptions.cs 100.00% <ø> (ø)
...ependencyInjection/PollyDependencyInjectionKeys.cs 100.00% <ø> (ø)
... and 14 more

... and 1 file with indirect coverage changes

@martintmk martintmk marked this pull request as ready for review August 9, 2023 07:24
@martintmk martintmk enabled auto-merge (squash) August 9, 2023 07:42
@martintmk martintmk merged commit 9674b6b into main Aug 9, 2023
@martintmk martintmk deleted the mtomka/cleanup-namespaces branch August 9, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants