Make ReactiveResilienceStrategy public
#1460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martincostello
approved these changes
Aug 8, 2023
| /// <param name="context">The context associated with the callback.</param> | ||
| /// <param name="state">The state associated with the callback.</param> | ||
| /// <returns> | ||
| /// An instance of pending <see cref="ValueTask"/> for asynchronous executions or completed <see cref="ValueTask"/> task for synchronous executions. |
There was a problem hiding this comment.
Suggested change
| /// An instance of pending <see cref="ValueTask"/> for asynchronous executions or completed <see cref="ValueTask"/> task for synchronous executions. | |
| /// An instance of a pending <see cref="ValueTask"/> for asynchronous executions or a completed <see cref="ValueTask"/> task for synchronous executions. |
| /// <remarks> | ||
| /// <strong>This method is called for both synchronous and asynchronous execution flows.</strong> | ||
| /// <para> | ||
| /// You can use <see cref="ResilienceContext.IsSynchronous"/> to determine whether the <paramref name="callback"/> is synchronous or asynchronous one. |
There was a problem hiding this comment.
Suggested change
| /// You can use <see cref="ResilienceContext.IsSynchronous"/> to determine whether the <paramref name="callback"/> is synchronous or asynchronous one. | |
| /// You can use <see cref="ResilienceContext.IsSynchronous"/> to determine whether <paramref name="callback"/> is synchronous or asynchronous. |
Codecov Report
@@ Coverage Diff @@
## main #1460 +/- ##
=======================================
Coverage 83.92% 83.92%
=======================================
Files 274 274
Lines 6506 6506
Branches 1012 1012
=======================================
Hits 5460 5460
Misses 837 837
Partials 209 209
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details on the issue fix or feature implementation
It is used as a base class for all reactive strategies. It should be public.
Confirm the following