Rename Attempt to AttemptNumber
#1447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1447 +/- ##
=======================================
Coverage 83.87% 83.87%
=======================================
Files 273 273
Lines 6505 6505
Branches 1010 1010
=======================================
Hits 5456 5456
Misses 840 840
Partials 209 209
Flags with carried forward coverage won't be shown. Click here to find out more.
|
martincostello
approved these changes
Jul 28, 2023
| @@ -8,12 +8,12 @@ public partial class ExecutionAttemptArguments | |||
| /// <summary> | |||
| /// Initializes a new instance of the <see cref="ExecutionAttemptArguments"/> class. | |||
| /// </summary> | |||
| /// <param name="attempt">The execution attempt.</param> | |||
| /// <param name="attemptNumber">The execution attempt.</param> | |||
There was a problem hiding this comment.
Suggested change
| /// <param name="attemptNumber">The execution attempt.</param> | |
| /// <param name="attemptNumber">The execution attempt number.</param> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details on the issue fix or feature implementation
Contributes to #1301
Confirm the following