Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix telemetry test failures #1439

Merged
merged 1 commit into from
Jul 27, 2023
Merged

Fix telemetry test failures #1439

merged 1 commit into from
Jul 27, 2023

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented Jul 27, 2023

Details on the issue fix or feature implementation

I have seen some test failures related to tracking of metering events. This change should isolate the tracking between tests.

Contributes to #1362

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label Jul 27, 2023
@martintmk martintmk added this to the v8.0.0 milestone Jul 27, 2023
@martintmk martintmk enabled auto-merge (squash) July 27, 2023 12:56
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #1439 (d660780) into main (65df668) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1439   +/-   ##
=======================================
  Coverage   83.94%   83.94%           
=======================================
  Files         276      276           
  Lines        6533     6533           
  Branches     1013     1013           
=======================================
  Hits         5484     5484           
  Misses        840      840           
  Partials      209      209           
Flag Coverage Δ
linux ?
macos 83.94% <ø> (ø)
windows 83.94% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@martintmk martintmk merged commit d810e5f into main Jul 27, 2023
@martintmk martintmk deleted the mtomka/fix-tests branch July 27, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants