Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename AddResilienceStrategy to AddResilienceStrategyRegistry #1397

Merged
merged 2 commits into from
Jul 12, 2023

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented Jul 12, 2023

Details on the issue fix or feature implementation

  • Rename the AddResilienceStrategy extensions that adds ResilienceStrategyRegistry service to AddResilienceStrategyRegistry.
  • Introduce AddResilienceStrategyRegistry overload that allows configuring ResilienceStrategyRegistryOptions inline.

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label Jul 12, 2023
@martintmk martintmk added this to the v8.0.0 milestone Jul 12, 2023
@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #1397 (31b9b24) into main (cebe145) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1397   +/-   ##
=======================================
  Coverage   83.79%   83.80%           
=======================================
  Files         273      273           
  Lines        6475     6476    +1     
  Branches     1010     1010           
=======================================
+ Hits         5426     5427    +1     
  Misses        840      840           
  Partials      209      209           
Flag Coverage Δ
linux ?
macos 83.80% <100.00%> (+<0.01%) ⬆️
windows 83.80% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...dencyInjection/PollyServiceCollectionExtensions.cs 100.00% <100.00%> (ø)

@martintmk martintmk enabled auto-merge (squash) July 12, 2023 07:57
@martintmk martintmk merged commit 715dbcc into main Jul 12, 2023
@martintmk martintmk deleted the mtomka/AddResilienceStrategyRegistry branch July 12, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants