Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kill mutant #1395

Merged
merged 1 commit into from
Jul 11, 2023
Merged

Kill mutant #1395

merged 1 commit into from
Jul 11, 2023

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented Jul 11, 2023

Details on the issue fix or feature implementation

I noticed this mutant sometimes fails the build. Just ignore it as it cannot be tested.

Contributes to #1362

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label Jul 11, 2023
@martintmk martintmk added this to the v8.0.0 milestone Jul 11, 2023
@martintmk martintmk enabled auto-merge (squash) July 11, 2023 13:54
@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Merging #1395 (d95ef6b) into main (472e961) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1395   +/-   ##
=======================================
  Coverage   83.73%   83.73%           
=======================================
  Files         270      270           
  Lines        6449     6449           
  Branches     1006     1006           
=======================================
  Hits         5400     5400           
  Misses        840      840           
  Partials      209      209           
Flag Coverage Δ
linux ?
macos ?
windows 83.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Polly.Core/Retry/RetryResilienceStrategy.cs 100.00% <ø> (ø)

@martintmk martintmk merged commit cebe145 into main Jul 11, 2023
@martintmk martintmk deleted the mtomka/kill-mutant branch July 11, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants