Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details on the issue fix or feature implementation
Dynamic reloads implementation can be simplified with a simple change. Instead of passing the
Func<CancellationToken>
we actually use a factory that produces theFunc<CancellationToken>
. This allows us to activate the factory only once when the strategy is being created and we do not have to handle multiple occurrences ofFunc<CancellationToken>
.As a part of this PR I am also hiding some API which might not be used outside of Polly. We can still unhide later.
Confirm the following