Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce ResilienceEventSeverity #1361

Merged
merged 5 commits into from
Jun 27, 2023
Merged

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented Jun 27, 2023

Details on the issue fix or feature implementation

Even though we are feature complete I want to squeeze this in to drop some workarounds around ExecutionAttempt event that should have informational severity. This change allows that.

Closes #1143

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label Jun 27, 2023
@martintmk martintmk added this to the v8.0.0 milestone Jun 27, 2023
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #1361 (4587a7a) into main (190f096) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1361      +/-   ##
==========================================
+ Coverage   83.56%   83.61%   +0.05%     
==========================================
  Files         268      268              
  Lines        6382     6403      +21     
  Branches     1001     1004       +3     
==========================================
+ Hits         5333     5354      +21     
  Misses        840      840              
  Partials      209      209              
Flag Coverage Δ
macos 83.61% <100.00%> (+0.05%) ⬆️
windows 83.61% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ircuitBreaker/Controller/CircuitStateController.cs 100.00% <100.00%> (ø)
.../Polly.Core/Fallback/FallbackResilienceStrategy.cs 100.00% <100.00%> (ø)
...rc/Polly.Core/Hedging/HedgingResilienceStrategy.cs 100.00% <100.00%> (ø)
src/Polly.Core/ResilienceContext.cs 100.00% <100.00%> (ø)
src/Polly.Core/Retry/RetryResilienceStrategy.cs 100.00% <100.00%> (ø)
src/Polly.Core/Telemetry/ResilienceEvent.cs 100.00% <100.00%> (ø)
...olly.Core/Telemetry/ResilienceStrategyTelemetry.cs 100.00% <100.00%> (ø)
...lly.Core/Telemetry/TelemetryEventArguments.Pool.cs 100.00% <100.00%> (ø)
...rc/Polly.Core/Telemetry/TelemetryEventArguments.cs 100.00% <100.00%> (ø)
src/Polly.Core/Telemetry/TelemetryUtil.cs 100.00% <100.00%> (ø)
... and 6 more

@martintmk martintmk enabled auto-merge (squash) June 27, 2023 13:02
@martintmk martintmk merged commit 49f7e2d into main Jun 27, 2023
@martintmk martintmk deleted the mtomka/resilience-event-severity branch June 27, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Expand the ResilienceEvent with the Severity
2 participants