Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate NuGet package signatures #1335

Merged
merged 2 commits into from
Jun 21, 2023
Merged

Conversation

martincostello
Copy link
Member

@martincostello martincostello commented Jun 21, 2023

A step to validate the NuGet package signature before pushing to NuGet.org with nuget verify.

Added in response to #1323 and #1333.

@martincostello martincostello added enhancement CI/build v8 Issues related to the new version 8 of the Polly library. labels Jun 21, 2023
@martincostello martincostello added this to the v8.0.0 milestone Jun 21, 2023
@martincostello
Copy link
Member Author

dotnet nuget verify $package is behaving as expected.

Verify the NuGet package signatures are valid before publishing to NuGet.org.
Remove some extra whitespace that VS Code removed.
@martincostello martincostello force-pushed the validate-package-signature branch from e0c8c79 to d4187d6 Compare June 21, 2023 10:57
@martincostello martincostello marked this pull request as ready for review June 21, 2023 10:57
@martincostello martincostello changed the title Test package signature validation Validate NuGet package signatures Jun 21, 2023
@martincostello martincostello requested a review from martintmk June 21, 2023 11:04
@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Merging #1335 (d4187d6) into main (73422d5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1335   +/-   ##
=======================================
  Coverage   83.53%   83.53%           
=======================================
  Files         269      269           
  Lines        6397     6397           
  Branches     1003     1003           
=======================================
  Hits         5344     5344           
  Misses        844      844           
  Partials      209      209           
Flag Coverage Δ
linux 83.53% <ø> (?)
macos 83.53% <ø> (ø)
windows 83.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@martincostello martincostello merged commit 2890e5a into main Jun 21, 2023
@martincostello martincostello deleted the validate-package-signature branch June 21, 2023 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/build enhancement v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants