Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API feedback #1327

Merged
merged 4 commits into from
Jun 19, 2023
Merged

API feedback #1327

merged 4 commits into from
Jun 19, 2023

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented Jun 19, 2023

Details on the issue fix or feature implementation

  • EnableTelemetry -> ConfigureTelemetry
  • In ResilienceStrategyRegistry and ResilienceStrategyProvider some methodnames are more explicit Get -> GetStrategy
  • AddStrategy extension method now returns the builder instead of just void. (reported in Observations about v8 API #1324)

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label Jun 19, 2023
@martintmk martintmk added this to the v8.0.0 milestone Jun 19, 2023
@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Merging #1327 (d4ce5d4) into main (04bd9ec) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1327   +/-   ##
=======================================
  Coverage   83.49%   83.49%           
=======================================
  Files         269      269           
  Lines        6379     6379           
  Branches     1004     1004           
=======================================
  Hits         5326     5326           
  Misses        844      844           
  Partials      209      209           
Flag Coverage Δ
linux ?
macos 83.49% <100.00%> (ø)
windows 83.49% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Polly.Core/ResilienceStrategyBuilderBase.cs 100.00% <ø> (ø)
...c/Polly.Core/Retry/RetryStrategyOptions.TResult.cs 100.00% <ø> (ø)
...rcuitBreakerResilienceStrategyBuilderExtensions.cs 100.00% <100.00%> (ø)
.../Polly.Core/Registry/ResilienceStrategyProvider.cs 100.00% <100.00%> (ø)
.../Polly.Core/Registry/ResilienceStrategyRegistry.cs 100.00% <100.00%> (ø)
.../Polly.Core/ResilienceStrategyBuilderExtensions.cs 100.00% <100.00%> (ø)
.../Retry/RetryResilienceStrategyBuilderExtensions.cs 100.00% <100.00%> (ø)
...dencyInjection/PollyServiceCollectionExtensions.cs 100.00% <100.00%> (ø)
...ry/TelemetryResilienceStrategyBuilderExtensions.cs 100.00% <100.00%> (ø)
.../RateLimiterResilienceStrategyBuilderExtensions.cs 100.00% <100.00%> (ø)

@martintmk martintmk enabled auto-merge (squash) June 19, 2023 15:02
@martintmk martintmk merged commit 91e5384 into main Jun 19, 2023
@martintmk martintmk deleted the mtomka/improve-addstrategy branch June 19, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants