Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance OnHedgingArguments #1314

Merged
merged 2 commits into from
Jun 16, 2023
Merged

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented Jun 16, 2023

Details on the issue fix or feature implementation

OnHedgingArguments is now a class because and also contains contains missed Context property. The class is fine in this case because it's not on a hot path and we can still enable pooling later.

The main reason for this change is to allow setting properties on OnHedgingArguments later for more advanced scenarios.
The action generator argument now also contains the PrimaryContext property which allows passing data between primary and secondary hedged tasks.

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label Jun 16, 2023
@martintmk martintmk added this to the v8.0.0 milestone Jun 16, 2023
@martintmk martintmk changed the title Enhance and pool OnHedgingArguments Enhance OnHedgingArguments Jun 16, 2023
@martintmk martintmk enabled auto-merge (squash) June 16, 2023 13:05
@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Merging #1314 (5961df9) into main (476f354) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1314      +/-   ##
==========================================
+ Coverage   83.28%   83.29%   +0.01%     
==========================================
  Files         264      264              
  Lines        6301     6305       +4     
  Branches      997      997              
==========================================
+ Hits         5248     5252       +4     
  Misses        844      844              
  Partials      209      209              
Flag Coverage Δ
linux ?
macos 83.29% <100.00%> (+0.01%) ⬆️
windows 83.29% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rc/Polly.Core/Hedging/Controller/HedgingHandler.cs 100.00% <100.00%> (ø)
src/Polly.Core/Hedging/Controller/TaskExecution.cs 100.00% <100.00%> (ø)
...ly.Core/Hedging/HedgingActionGeneratorArguments.cs 100.00% <100.00%> (ø)
...rc/Polly.Core/Hedging/HedgingResilienceStrategy.cs 100.00% <100.00%> (ø)
...lly.Core/Hedging/HedgingStrategyOptions.TResult.cs 100.00% <100.00%> (ø)
src/Polly.Core/Hedging/OnHedgingArguments.cs 100.00% <100.00%> (ø)

@martintmk martintmk merged commit 488bc10 into main Jun 16, 2023
@martintmk martintmk deleted the mtomka/onheding-args-improvements branch June 16, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants