Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log unhealthy executions with warning level #1306

Merged
merged 3 commits into from
Jun 15, 2023
Merged

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented Jun 15, 2023

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label Jun 15, 2023
@martintmk martintmk added this to the v8.0.0 milestone Jun 15, 2023
@martintmk
Copy link
Contributor Author

Noticed this while working on samples.

@martintmk martintmk enabled auto-merge (squash) June 15, 2023 07:56
@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Merging #1306 (5b6e2a2) into main (833ad99) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1306   +/-   ##
=======================================
  Coverage   83.28%   83.28%           
=======================================
  Files         263      264    +1     
  Lines        6299     6301    +2     
  Branches      994      997    +3     
=======================================
+ Hits         5246     5248    +2     
  Misses        844      844           
  Partials      209      209           
Flag Coverage Δ
macos 83.28% <100.00%> (+<0.01%) ⬆️
windows 83.28% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...xtensions/Telemetry/ResilienceContextExtensions.cs 100.00% <100.00%> (ø)
...xtensions/Telemetry/TelemetryResilienceStrategy.cs 100.00% <100.00%> (ø)

... and 7 files with indirect coverage changes

@martintmk martintmk merged commit 0d8061d into main Jun 15, 2023
@martintmk martintmk deleted the mtomka/improve-logging branch June 15, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants