Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop allocations when using ResilienceProperties #1276

Merged
merged 1 commit into from
Jun 12, 2023

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented Jun 12, 2023

Details on the issue fix or feature implementation

Add a type check for a plain dictionary to avoid enumerator allocation.

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label Jun 12, 2023
@martintmk martintmk added this to the v8.0.0 milestone Jun 12, 2023
@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Merging #1276 (22279f1) into main (a908391) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1276   +/-   ##
=======================================
  Coverage   83.33%   83.33%           
=======================================
  Files         270      270           
  Lines        6317     6320    +3     
  Branches      981      983    +2     
=======================================
+ Hits         5264     5267    +3     
  Misses        844      844           
  Partials      209      209           
Flag Coverage Δ
linux 83.33% <100.00%> (+<0.01%) ⬆️
macos 83.33% <100.00%> (+<0.01%) ⬆️
windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Polly.Core/ResilienceProperties.cs 100.00% <100.00%> (ø)

@martintmk martintmk enabled auto-merge (squash) June 12, 2023 06:46
@martintmk martintmk merged commit 452613b into main Jun 12, 2023
@martintmk martintmk deleted the mtomka/hedging-allocations branch June 12, 2023 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants