Fix CI version in main #1273
Merged
Fix CI version in main #1273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use Minimal MSBuild verbosity for `dotnet clean` to match other targets.
- Use `v8alpha` tag for pre-release builds in `main`. - Use the default file name for GitVersion configuration. - Include the build version in the assembly file version. - Remove logging of the informational version that isn't what we use.
The new C# Dev Kit keeps creating this file in the repo, so checking it in.
martincostello
added
CI/build
v8
Use `CommitsSinceVersionSource` instead of `BuildMetaData` as that doesn't seem to be set in PRs.
Codecov Report
@@ Coverage Diff @@
## main #1273 +/- ##
=======================================
Coverage 83.33% 83.33%
=======================================
Files 270 270
Lines 6317 6317
Branches 981 981
=======================================
Hits 5264 5264
Misses 844 844
Partials 209 209
Flags with carried forward coverage won't be shown. Click here to find out more. |
martincostello
commented
Jun 9, 2023
| next-version: 8.0.0 | ||
| branches: | ||
| main: | ||
| tag: v8alpha |
There was a problem hiding this comment.
I've updated this based on our conversation yesterday, though the v8 prefix seems redundant to me.
|
Hmm - the package version is still 8.0.0... |
Fix missing pre-release suffix for the NuGet packages.
We don't have packages with and without strong names anymore, so remove the word "Signed" to prevent confusion with Authenticode signing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v8alphatag for pre-release builds inmain..vscode/settings.jsonfile the new C# Dev Kit keeps creating.dotnet cleanto match other targets.Resolves #1270.