Improve the V8 -> V7 bridge implementation and add benchmarks #1257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martincostello
approved these changes
Jun 6, 2023
| | Method | Mean | Error | StdDev | Ratio | RatioSD | Gen0 | Allocated | Alloc Ratio | | ||
| |----------------------- |----------:|---------:|---------:|------:|--------:|-------:|----------:|------------:| | ||
| | NoOpAsync | 85.38 ns | 1.001 ns | 1.371 ns | 1.00 | 0.00 | 0.0120 | 304 B | 1.00 | | ||
| | NullResilienceStrategy | 416.38 ns | 1.924 ns | 2.820 ns | 4.87 | 0.10 | 0.0148 | 376 B | 1.24 | |
There was a problem hiding this comment.
Yup, there is a resilience context lookup, lambda conversion, and bunch of other stuff. It really adds up.
Codecov Report
@@ Coverage Diff @@
## main #1257 +/- ##
==========================================
+ Coverage 83.08% 83.12% +0.04%
==========================================
Files 268 269 +1
Lines 6218 6239 +21
Branches 979 976 -3
==========================================
+ Hits 5166 5186 +20
- Misses 843 844 +1
Partials 209 209
Flags with carried forward coverage won't be shown. Click here to find out more.
|
martintmk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue or feature being addressed
Follow up of #1255
Details on the issue fix or feature implementation
While playing with bridge I noticed some issues:
ResiliencePropertiesneed to use the same dictionary asContext. I have introduced pub-internalLegacySupportthat allows this scenario.Polly.Legacy.Contextvalue unnecessary, we can use the state for that and avoid dictionary lookup.Additionally, I have added the benchmark for the bride. It reveals the non-trivial overhead.
Confirm the following