Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Outcome.EnsureSuccess #1243

Merged
merged 2 commits into from
Jun 1, 2023
Merged

Introduce Outcome.EnsureSuccess #1243

merged 2 commits into from
Jun 1, 2023

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented Jun 1, 2023

Details on the issue fix or feature implementation

This PR introduces Outcome.EnsureSuccess API and does some small cleanup.

Contributes to #1238.

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label Jun 1, 2023
@martintmk martintmk added this to the v8.0.0 milestone Jun 1, 2023
@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Merging #1243 (1b80405) into main (4ec50a9) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1243      +/-   ##
==========================================
+ Coverage   82.79%   82.81%   +0.01%     
==========================================
  Files         265      265              
  Lines        6096     6103       +7     
  Branches      966      967       +1     
==========================================
+ Hits         5047     5054       +7     
  Misses        844      844              
  Partials      205      205              
Flag Coverage Δ
linux 82.81% <100.00%> (?)
windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Polly.Core/Registry/ConfigureBuilderContext.cs 100.00% <100.00%> (ø)
src/Polly.Core/Strategy/Outcome.cs 100.00% <100.00%> (ø)
...ependencyInjection/AddResilienceStrategyContext.cs 100.00% <100.00%> (ø)

@martintmk martintmk merged commit b6f8d2b into main Jun 1, 2023
@martintmk martintmk deleted the mtomka/add-ensure-success branch June 1, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants