Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose ExecuteOutcomeAsync and use it in benchmarks #1209

Merged
merged 3 commits into from
May 23, 2023

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented May 23, 2023

Details on the issue fix or feature implementation

The ExecuteOutcomeAsync is lower-level API that avoids constant overhead of around 120ns (on my PC) for every strategy. It's the API we will be using internally.

This also puts V8 firmly ahead of V7 in almost all benchmarks.

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added this to the v8.0.0 milestone May 23, 2023
@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label May 23, 2023
@martintmk martintmk enabled auto-merge (squash) May 23, 2023 13:30
@martintmk martintmk disabled auto-merge May 23, 2023 13:46
@martintmk martintmk enabled auto-merge (squash) May 23, 2023 14:13
@martintmk martintmk merged commit 2e0d754 into main May 23, 2023
@martintmk martintmk deleted the mtomka/expose-executeoutcomeasync branch May 23, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants