Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve benchmarks #1206

Merged
merged 4 commits into from
May 23, 2023
Merged

Improve benchmarks #1206

merged 4 commits into from
May 23, 2023

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented May 23, 2023

Details on the issue fix or feature implementation

I got tired of always updating the README.md with the latest results. It's better to just add the markdown output directly to the repo.

Additional changes:

  • Fixed timeout benchmark which got broken recently.
  • Simplified running the benchmarks. (options to run all or pick them)
  • Added new benchmark.

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk requested a review from martincostello May 23, 2023 05:52
@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label May 23, 2023
@martintmk martintmk added this to the v8.0.0 milestone May 23, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 23, 2023

Codecov Report

Merging #1206 (5372a8e) into main (e4540c8) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main    #1206   +/-   ##
=======================================
  Coverage   83.31%   83.31%           
=======================================
  Files         277      277           
  Lines        6286     6286           
  Branches     1023     1023           
=======================================
  Hits         5237     5237           
  Misses        844      844           
  Partials      205      205           
Flag Coverage Δ
macos 83.31% <ø> (ø)
windows 83.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@martintmk martintmk changed the title Upload benchmark results Improve benchmarks May 23, 2023
@martintmk martintmk merged commit cc28c5e into main May 23, 2023
@martintmk martintmk deleted the mtomka/upload-benchmark-results branch May 23, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants