Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify AddStrategy method #1203

Merged
merged 3 commits into from
May 22, 2023
Merged

Simplify AddStrategy method #1203

merged 3 commits into from
May 22, 2023

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented May 21, 2023

Details on the issue fix or feature implementation

Dropping the ResilienceStrategyOptions argument from the AddStrategy method that accepts pre-created strategy. In this case the options are never used so there is no need to pass them.

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label May 21, 2023
@martintmk martintmk added this to the v8.0.0 milestone May 21, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 21, 2023

Codecov Report

Merging #1203 (46c30c5) into main (92083bb) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main    #1203   +/-   ##
=======================================
  Coverage   83.18%   83.18%           
=======================================
  Files         273      273           
  Lines        6239     6240    +1     
  Branches     1023     1023           
=======================================
+ Hits         5190     5191    +1     
  Misses        844      844           
  Partials      205      205           
Flag Coverage Δ
linux 83.18% <100.00%> (+<0.01%) ⬆️
macos 83.18% <100.00%> (+<0.01%) ⬆️
windows 83.18% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Polly.Core/ResilienceStrategyBuilder.cs 100.00% <100.00%> (ø)

@martintmk martintmk merged commit 8dc4eb5 into main May 22, 2023
@martintmk martintmk deleted the mtomka/simplify-addstrategy branch May 22, 2023 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants