Preliminary API Review (2) #1186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martincostello
approved these changes
May 16, 2023
Comment on lines
26
to
28
| /// Make sure that the action returned by the generator represents a real asynchronous work, otherwise the hedging | ||
| /// engine will be blocked and parallel hedged actions won't ever be executed. The generator can return a <see langword="null"/> function. | ||
| /// In such case the hedging is not executed for that attempt. |
There was a problem hiding this comment.
Suggested change
| /// Make sure that the action returned by the generator represents a real asynchronous work, otherwise the hedging | |
| /// engine will be blocked and parallel hedged actions won't ever be executed. The generator can return a <see langword="null"/> function. | |
| /// In such case the hedging is not executed for that attempt. | |
| /// Make sure that the action returned by the generator represents real asynchronous work, otherwise the hedging | |
| /// engine will be blocked and parallel hedged actions won't ever be executed. The generator can return a <see langword="null"/> function. | |
| /// In such a case the hedging is not executed for that attempt. |
Comment on lines
25
to
27
| /// Make sure that the action returned by the generator represents a real asynchronous work, otherwise the hedging | ||
| /// engine will be blocked and parallel hedged actions won't ever be executed. The generator can return a <see langword="null"/> function. | ||
| /// In such case the hedging is not executed for that attempt. |
There was a problem hiding this comment.
Suggested change
| /// Make sure that the action returned by the generator represents a real asynchronous work, otherwise the hedging | |
| /// engine will be blocked and parallel hedged actions won't ever be executed. The generator can return a <see langword="null"/> function. | |
| /// In such case the hedging is not executed for that attempt. | |
| /// Make sure that the action returned by the generator represents real asynchronous work, otherwise the hedging | |
| /// engine will be blocked and parallel hedged actions won't ever be executed. The generator can return a <see langword="null"/> function. | |
| /// In such a case the hedging is not executed for that attempt. |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #1186 +/- ##
==========================================
- Coverage 83.42% 83.40% -0.03%
==========================================
Files 273 273
Lines 6329 6321 -8
Branches 1028 1028
==========================================
- Hits 5280 5272 -8
Misses 844 844
Partials 205 205
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details on the issue fix or feature implementation
Just addressing some of the issues found when doing internal API review. We want to do some initial pass before we engage with broader audience.
Func<> instead.Outcome.System.Threading.Timeout.InfiniteTimeSpaninstead of custom API.Confirm the following