Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial preliminary API Review (1) #1185

Merged
merged 1 commit into from
May 15, 2023
Merged

Initial preliminary API Review (1) #1185

merged 1 commit into from
May 15, 2023

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented May 15, 2023

Details on the issue fix or feature implementation

Just addressing some of the issues found when doing internal API review. We want to do some initial pass before we engage with broader audience.

  • Using defaults for CancellationToken.
  • Fixed some docs.
  • Hiding IsEmpty from callback API.

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label May 15, 2023
@martintmk martintmk added this to the v8.0.0 milestone May 15, 2023
@martintmk martintmk changed the title Initial API Review Initial preliminary API Review (1) May 15, 2023
@martintmk martintmk force-pushed the mtomka/api-review-1 branch from 92b8238 to 2a98a87 Compare May 15, 2023 17:52
@codecov-commenter
Copy link

codecov-commenter commented May 15, 2023

Codecov Report

Merging #1185 (2a98a87) into main (3ff908a) will not change coverage.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main    #1185   +/-   ##
=======================================
  Coverage   83.42%   83.42%           
=======================================
  Files         273      273           
  Lines        6329     6329           
  Branches     1028     1028           
=======================================
  Hits         5280     5280           
  Misses        844      844           
  Partials      205      205           
Flag Coverage Δ
macos 83.42% <100.00%> (ø)
windows 83.42% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...eaker/BaseCircuitBreakerStrategyOptions.TResult.cs 100.00% <ø> (ø)
...ircuitBreaker/BaseCircuitBreakerStrategyOptions.cs 100.00% <ø> (ø)
...Core/CircuitBreaker/CircuitBreakerManualControl.cs 100.00% <ø> (ø)
...y.Core/Fallback/FallbackStrategyOptions.TResult.cs 100.00% <ø> (ø)
src/Polly.Core/Hedging/HedgingHandler.TResult.cs 100.00% <ø> (ø)
src/Polly.Core/Hedging/VoidHedgingHandler.cs 100.00% <ø> (ø)
src/Polly.Core/ResilienceStrategy.Async.Task.cs 100.00% <ø> (ø)
src/Polly.Core/ResilienceStrategy.Async.TaskT.cs 100.00% <ø> (ø)
src/Polly.Core/ResilienceStrategy.SyncT.cs 100.00% <ø> (ø)
src/Polly.Core/Strategy/Outcome.TResult.cs 100.00% <ø> (ø)
... and 14 more

@martintmk martintmk enabled auto-merge (squash) May 15, 2023 18:02
@martintmk martintmk merged commit e6b3e00 into main May 15, 2023
@martintmk martintmk deleted the mtomka/api-review-1 branch May 15, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants