Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more execute methods for ResilienceStrategy #1170

Merged
merged 1 commit into from
May 2, 2023

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented May 2, 2023

The issue or feature being addressed

Closes #1069

Details on the issue fix or feature implementation

Just added more convienience Execute* methods to ResilienceStrategy

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@codecov-commenter
Copy link

codecov-commenter commented May 2, 2023

Codecov Report

Merging #1170 (5b55740) into main (2d47e4f) will increase coverage by 0.45%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1170      +/-   ##
==========================================
+ Coverage   83.03%   83.49%   +0.45%     
==========================================
  Files         272      272              
  Lines        6183     6355     +172     
  Branches     1006     1018      +12     
==========================================
+ Hits         5134     5306     +172     
  Misses        844      844              
  Partials      205      205              
Flag Coverage Δ
linux 83.49% <100.00%> (?)
macos 83.49% <100.00%> (+0.45%) ⬆️
windows 83.49% <100.00%> (+0.45%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Polly.Core/ResilienceStrategy.Async.Task.cs 100.00% <100.00%> (ø)
src/Polly.Core/ResilienceStrategy.Async.TaskT.cs 100.00% <100.00%> (ø)
...c/Polly.Core/ResilienceStrategy.Async.ValueTask.cs 100.00% <100.00%> (ø)
.../Polly.Core/ResilienceStrategy.Async.ValueTaskT.cs 100.00% <100.00%> (ø)
src/Polly.Core/ResilienceStrategy.Sync.cs 100.00% <100.00%> (ø)
src/Polly.Core/ResilienceStrategy.SyncT.cs 100.00% <100.00%> (ø)

@martintmk martintmk self-assigned this May 2, 2023
@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label May 2, 2023
@martintmk martintmk added this to the v8.0.0 milestone May 2, 2023
@martintmk martintmk merged commit ceb89b5 into main May 2, 2023
@martintmk martintmk deleted the mtomka/execute-extensions branch May 2, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Introduce additional execute methods for ResilienceStrategy
3 participants