Skip to content

Commit

Permalink
PR comments
Browse files Browse the repository at this point in the history
  • Loading branch information
martintmk committed Aug 15, 2023
1 parent 10421d1 commit d441426
Show file tree
Hide file tree
Showing 14 changed files with 14 additions and 14 deletions.
2 changes: 1 addition & 1 deletion src/Polly.Core/CircuitBreaker/OnCircuitClosedArguments.cs
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ namespace Polly.CircuitBreaker;
/// Arguments used by <see cref="CircuitBreakerStrategyOptions{TResult}.OnClosed"/> event.
/// </summary>
/// <remarks>
/// Always use constructor when creating this struct, otherwise we do not guarantee the binary compatibility.
/// Always use the constructor when creating this struct, otherwise we do not guarantee binary compatibility.
/// </remarks>
public readonly struct OnCircuitClosedArguments
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ namespace Polly.CircuitBreaker;
/// Arguments used by <see cref="CircuitBreakerStrategyOptions{TResult}.OnHalfOpened"/> event.
/// </summary>
/// <remarks>
/// Always use constructor when creating this struct, otherwise we do not guarantee the binary compatibility.
/// Always use the constructor when creating this struct, otherwise we do not guarantee binary compatibility.
/// </remarks>
public readonly struct OnCircuitHalfOpenedArguments
{
Expand Down
2 changes: 1 addition & 1 deletion src/Polly.Core/CircuitBreaker/OnCircuitOpenedArguments.cs
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ namespace Polly.CircuitBreaker;
/// Arguments used by <see cref="CircuitBreakerStrategyOptions{TResult}.OnOpened"/> event.
/// </summary>
/// <remarks>
/// Always use constructor when creating this struct, otherwise we do not guarantee the binary compatibility.
/// Always use the constructor when creating this struct, otherwise we do not guarantee binary compatibility.
/// </remarks>
public readonly struct OnCircuitOpenedArguments
{
Expand Down
2 changes: 1 addition & 1 deletion src/Polly.Core/Fallback/OnFallbackArguments.cs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ namespace Polly.Fallback;
/// Represents arguments used in fallback handling scenarios.
/// </summary>
/// <remarks>
/// Always use constructor when creating this struct, otherwise we do not guarantee the binary compatibility.
/// Always use the constructor when creating this struct, otherwise we do not guarantee binary compatibility.
/// </remarks>
public readonly struct OnFallbackArguments
{
Expand Down
2 changes: 1 addition & 1 deletion src/Polly.Core/Hedging/OnHedgingArguments.cs
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ namespace Polly.Hedging;
/// Represents arguments used by the on-hedging event.
/// </summary>
/// <remarks>
/// Always use constructor when creating this struct, otherwise we do not guarantee the binary compatibility.
/// Always use the constructor when creating this struct, otherwise we do not guarantee binary compatibility.
/// </remarks>
public readonly struct OnHedgingArguments
{
Expand Down
2 changes: 1 addition & 1 deletion src/Polly.Core/Retry/OnRetryArguments.cs
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ namespace Polly.Retry;
/// Represents the arguments used by <see cref="RetryStrategyOptions{TResult}.OnRetry"/> for handling the retry event.
/// </summary>
/// <remarks>
/// Always use constructor when creating this struct, otherwise we do not guarantee the binary compatibility.
/// Always use the constructor when creating this struct, otherwise we do not guarantee binary compatibility.
/// </remarks>
public readonly struct OnRetryArguments
{
Expand Down
2 changes: 1 addition & 1 deletion src/Polly.Core/Telemetry/ExecutionAttemptArguments.cs
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
/// Arguments that encapsulate the execution attempt for retries or hedging.
/// </summary>
/// <remarks>
/// Always use constructor when creating this struct, otherwise we do not guarantee the binary compatibility.
/// Always use the constructor when creating this struct, otherwise we do not guarantee binary compatibility.
/// </remarks>
public readonly struct ExecutionAttemptArguments
{
Expand Down
2 changes: 1 addition & 1 deletion src/Polly.Core/Telemetry/PipelineExecutedArguments.cs
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
/// Arguments that indicate the pipeline execution started.
/// </summary>
/// <remarks>
/// Always use constructor when creating this struct, otherwise we do not guarantee the binary compatibility.
/// Always use the constructor when creating this struct, otherwise we do not guarantee binary compatibility.
/// </remarks>
public readonly struct PipelineExecutedArguments
{
Expand Down
2 changes: 1 addition & 1 deletion src/Polly.Core/Telemetry/PipelineExecutingArguments.cs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
/// Arguments that indicate the pipeline execution started.
/// </summary>
/// <remarks>
/// Always use constructor when creating this struct, otherwise we do not guarantee the binary compatibility.
/// Always use the constructor when creating this struct, otherwise we do not guarantee binary compatibility.
/// </remarks>
public readonly struct PipelineExecutingArguments
{
Expand Down
2 changes: 1 addition & 1 deletion src/Polly.Core/Telemetry/TelemetryEventArguments.cs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
/// <typeparam name="TResult">The type of result.</typeparam>
/// <typeparam name="TArgs">The arguments associated with the resilience event.</typeparam>
/// <remarks>
/// Always use constructor when creating this struct, otherwise we do not guarantee the binary compatibility.
/// Always use the constructor when creating this struct, otherwise we do not guarantee binary compatibility.
/// </remarks>
public readonly struct TelemetryEventArguments<TResult, TArgs>
{
Expand Down
2 changes: 1 addition & 1 deletion src/Polly.Core/Timeout/OnTimeoutArguments.cs
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ namespace Polly.Timeout;
/// Arguments used by the timeout strategy to notify that a timeout occurred.
/// </summary>
/// <remarks>
/// Always use constructor when creating this struct, otherwise we do not guarantee the binary compatibility.
/// Always use the constructor when creating this struct, otherwise we do not guarantee binary compatibility.
/// </remarks>
public readonly struct OnTimeoutArguments
{
Expand Down
2 changes: 1 addition & 1 deletion src/Polly.Core/Timeout/TimeoutGeneratorArguments.cs
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ namespace Polly.Timeout;
/// Arguments used by the timeout strategy to retrieve a timeout for current execution.
/// </summary>
/// <remarks>
/// Always use constructor when creating this struct, otherwise we do not guarantee the binary compatibility.
/// Always use the constructor when creating this struct, otherwise we do not guarantee binary compatibility.
/// </remarks>
public readonly struct TimeoutGeneratorArguments
{
Expand Down
2 changes: 1 addition & 1 deletion src/Polly.Extensions/Telemetry/EnrichmentContext.cs
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
/// <typeparam name="TArgs">The type of the arguments attached to the resilience event.</typeparam>
/// <remarks>
/// This context is passed to enrichers in <see cref="TelemetryOptions.MeteringEnrichers"/>.
/// Always use constructor when creating this struct, otherwise we do not guarantee the binary compatibility.
/// Always use the constructor when creating this struct, otherwise we do not guarantee binary compatibility.
/// </remarks>
public readonly struct EnrichmentContext<TResult, TArgs>
{
Expand Down
2 changes: 1 addition & 1 deletion src/Polly.RateLimiting/OnRateLimiterRejectedArguments.cs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ namespace Polly.RateLimiting;
/// The arguments used by the <see cref="RateLimiterStrategyOptions.OnRejected"/>.
/// </summary>
/// <remarks>
/// Always use constructor when creating this struct, otherwise we do not guarantee the binary compatibility.
/// Always use the constructor when creating this struct, otherwise we do not guarantee binary compatibility.
/// </remarks>
public readonly struct OnRateLimiterRejectedArguments
{
Expand Down

0 comments on commit d441426

Please sign in to comment.