-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better example display #595
Open
Haniyya
wants to merge
40
commits into
Apipie:master
Choose a base branch
from
lokalportal:feature/better-example-display
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Better example display #595
Haniyya
wants to merge
40
commits into
Apipie:master
from
lokalportal:feature/better-example-display
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the 'request_data_json' field.
WIP since i probably need to fix/write some tests still. |
Would it be possible to split the PR into some smaller isolated PRs that could be reviewed separately? Big PRs are usually harder to tackle. |
@iNecas I could split it into 3 that correlate to the three features mentioned above if thats okay. |
Yes please |
… the 'request_data_json' field.
This was referenced Jan 18, 2018
…ipts and Apipie.include_stylesheets and finally deleted the corresponding files themselves.
Updated bootstrap css and js
ofedoren
force-pushed
the
master
branch
2 times, most recently
from
July 25, 2021 19:41
69442b9
to
8215e30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Improves and fixes changes to the UI that were introduced in #598 and starts to utilize #597 as well.
As these changes are depended on their predecessors, i advise to merge those first as the changes will become minimal once they are incorporated.
This PR basically isolates certain markdown related things that were not needed for the changes in the PRs mentioned above but will be necessary for a good user experience once those are merged.