APERTA-7947 chore/Inline ember-cli-lazyloader #2658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'd like to start looking at using [yarn](https://yarnpkg.com/) as a npm client. A fresh npm install takes 2 minutes and 40 seconds on my machine, whereas a fresh yarn install takes about 40 seconds. Our ember-cli-lazyloader dependency currently isn't compatible. This is the only package we have that's not listed on the npm registry. It's a standalone repo for a small file, so I've brought the code inline here.
|
Yes. 👍 |
|
👍 I confirmed that lazy loading is still working by verifying that MathJax is loading and Math is being rendered properly. |
Bestra
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to jira ticket: https://developer.plos.org/jira/browse/APERTA-7947
I'd like to start looking at using yarn as a
npm client. Why?
machine, whereas a fresh yarn install takes about 40 seconds.
and (it seems) more deterministic.
Our ember-cli-lazyloader dependency currently isn't compatible (for now, see yarnpkg/yarn#513), and after taking a look I think it's worth inlining it.
This is the only package we have that's not listed on the npm registry.
It's a standalone repo for a small file, so I've brought the code into aperta.
If everything works out I'll be using yarn locally and then updating the shrinkwrap as needed until we can evaluate it further.