fix: issue where always would raise a warning [APE-1533]

solcx/install.py

@@ -709,7 +709,7 @@ def _validate_installation(version: Version, solcx_binary_path: Union[Path, str,
         raise UnexpectedVersionError(
             f"Attempted to install solc v{version}, but got solc v{installed_version}"
         )
-    if installed_version_clean not in (version.base_version, f"{version}"):
+    if installed_version not in (version.base_version, f"{version}"):
         # If it does have the nightly suffix, then only warn.
         warnings.warn(
             f"Installed solc version is v{installed_version}, expecting v{version.base_version}",

tests/install/test_validate_installation.py

@@ -1,11 +1,25 @@
 import sys
+import warnings
 
 import pytest
 
 import solcx
 from solcx.exceptions import SolcInstallationError, UnexpectedVersionError, UnexpectedVersionWarning
 
 
+def test_validate_installation(mocker, install_mock, solc_binary, install_path):
+    version = solcx.wrapper.get_solc_version(solc_binary)
+    version_str_patch = mocker.patch("solcx.wrapper.get_version_str_from_solc_binary")
+    version_str_patch.return_value = f"{version}"
+
+    # This should not warn!
+    with warnings.catch_warnings():
+        warnings.simplefilter("error")
+        solcx.install_solc()
+
+    assert install_path.exists()
+
+
 def test_validate_installation_wrong_version(mocker, install_mock, install_path):
     patch = mocker.patch("solcx.wrapper.get_version_str_from_solc_binary")
     patch.return_value = "0.0.0"