Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: struct-log based trace-frames now include events emitted #66

Merged
merged 5 commits into from
Jun 26, 2024

Conversation

antazoey
Copy link
Member

What I did

Part 1 of getting events into traces, focusing on low level frame data from struct logs because we can accurately inject events into the appropriate parts of the call tree this way

How I did it

How to verify it

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

@antazoey antazoey marked this pull request as ready for review June 25, 2024 17:49
@antazoey antazoey force-pushed the feat/events-in-traces branch from c1815f7 to 796d753 Compare June 25, 2024 17:49
@antazoey antazoey changed the title feat: getting events into traces feat: struct-log based trace-frames now include events emitted Jun 25, 2024
return CallTreeNode(**node_kwargs)


def _create_event_node(frame: TraceFrame) -> EventNode:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the magic

@antazoey antazoey requested a review from fubuloubu June 25, 2024 17:51
@antazoey antazoey merged commit dbbd986 into ApeWorX:main Jun 26, 2024
15 checks passed
@antazoey antazoey deleted the feat/events-in-traces branch June 26, 2024 23:37
@antazoey antazoey restored the feat/events-in-traces branch June 27, 2024 21:21
@antazoey antazoey deleted the feat/events-in-traces branch August 16, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants