generated from ApeWorX/project-template
-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove setuptools dependency (bump pyevm to 0.9.0-beta.1) #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
bump pyevm
aw feck, trying to install ape results in dependency hell
|
3 tasks
* make py-evm dependency more explicit for pip * add back py-evm dependency cap
wakamex
changed the title
chore: bump pyevm to >=0.9
chore: remove setuptools dependency (bump pyevm to 0.9.0-beta.1)
Apr 15, 2024
antazoey
approved these changes
Apr 15, 2024
actually have to do this first @NotPeopling2day #63 |
NotPeopling2day
approved these changes
Apr 15, 2024
isn't this identical to #63? (just with a different version) |
one we could do, one has to wait. |
oh web3.py released again, so we could have done this. lol. sorry! |
antazoey
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
fixes shadow dependency on setuptools, because py-evm < 0.9 uses pkg_resources to set its version without listing setuptools as a dependency.
working toward fully removed dependence on setuptools in ape, tracking PR here: ApeWorX/ape#2003
might break something since I don't know why the cap was there in the first place, but the tests pass
How I did it
remove capped dependency, and set minimum to first version of py-evm that uses importlib instead of pkg_resources (0.9)
How to verify it
Checklist