Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tpt update and fetch one by candidate key #65

Merged
merged 6 commits into from
Dec 15, 2019

Conversation

AnyhowStep
Copy link
Owner

Still needs a lot of clean up and tests, just making the PR before I complete it

@codecov-io
Copy link

codecov-io commented Dec 13, 2019

Codecov Report

Merging #65 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #65      +/-   ##
=========================================
+ Coverage   95.95%     96%   +0.04%     
=========================================
  Files        1050    1054       +4     
  Lines       48305   48651     +346     
  Branches     2579    2606      +27     
=========================================
+ Hits        46353   46707     +354     
+ Misses       1942    1934       -8     
  Partials       10      10
Impacted Files Coverage Δ
...-table-per-type/util/execution/insert-and-fetch.ts 98.38% <100%> (-0.51%) ⬇️
...sign-pattern-table-per-type/table-per-type-impl.ts 100% <100%> (ø) ⬆️
...attern-table-per-type/util/execution/absorb-row.ts 100% <100%> (ø)
src/table/table-impl.ts 100% <100%> (ø) ⬆️
...r-type/util/execution/update-and-fetch-one-impl.ts 100% <100%> (ø)
src/expr-library/control-flow/coalesce.ts 100% <100%> (ø) ⬆️
...-type/util/execution/invoke-assignment-delegate.ts 100% <100%> (ø)
...c/column/array-util/constructor/from-column-map.ts 100% <100%> (ø) ⬆️
...execution/update-and-fetch-one-by-candidate-key.ts 100% <100%> (ø)
src/expr-library/control-flow/if-null.ts 100% <100%> (ø) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34264df...b22504b. Read the comment docs.

@AnyhowStep
Copy link
Owner Author

AnyhowStep commented Dec 15, 2019

Just added a commit that fixes #25 by using a trampoline type.

https://github.com/AnyhowStep/tsql/pull/65/files#diff-0214b2fefabaf1617e690660683db775R226-R237

@AnyhowStep AnyhowStep merged commit 89f39a6 into master Dec 15, 2019
@AnyhowStep AnyhowStep deleted the tpt-update-and-fetch-one-by-candidate-key branch January 11, 2020 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants