Added a new field : UniqueField #8
Conversation
…y inside a given model database, within schema validation. Built on the model of InstanceField
…alues are displayed when validating a list
|
@AlexTorx Looks good, thanks! |
|
|
||
| class TestSchema(Schema): | ||
| uuid = fields.UniqueField( | ||
| cls_or_instance_type=fields.List(fields.UUID()), |
|
It would be necessary to share the code between the fields which uses a subfield |
| if not value: | ||
| raise ValidationError("Field may not be null.") | ||
|
|
||
| if isinstance(self.container, List): |
There was a problem hiding this comment.
This structure is bizarre, because the notion of fields.List means that the field is multiple whereas it is the value.
it is as if to test the color of the steering wheel of a car, it is considered that a car has several wheels.
personally I am against
There was a problem hiding this comment.
Ok right I guess I got it. But then since I adapted my code regarding the InstanceField field, why is it different, since this field implements some checks for fields.List cases ?
There was a problem hiding this comment.
For me, it is not a list of entry, and it must be only for the post. I think it have not be a field but a validator and only for the serialization.
I will see this evening, If I find a better way
Do you mean create a generical field that should not be instanciated and that contains all methods, and let InstanceField and UniqueField heritate from that new class and re-define the _validate method depending on what the field is actually supposed to validate ? |
|
Yes, a generic class called "mixin". Python allow multi inheritance dependencies |
…ping simplier ones
Does it look better now ? I have created a "Mixin" class that implements all common methods between InstanceField and UniqueField as well as a dummy _validate method that is supposed to be overloaded. |
This fields aims at ensuring unicity of a field which property 'unique' was set to true, and check this through schema validation.
It has quite the same implementation as the InstanceField but raises ValidationError if the specified value is already used in the given field in the database table.
Tests were written on the same basis as tests for the InstanceField.