CHG autograde test item #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
synoet
reviewed
Oct 9, 2021
| const SubmissionTest = ({ | ||
| }) =>{ | ||
| const classes = useStyles(); | ||
| const submission = { |
There was a problem hiding this comment.
Please remove the test data, and add the proper ones for props.
synoet
reviewed
Oct 10, 2021
| import FiberManualRecordIcon from '@material-ui/icons/FiberManualRecord'; | ||
|
|
||
|
|
||
| export default function SubmissionTest({tests}) { |
There was a problem hiding this comment.
Submission test should take the values needed to render one instance of your component not all the tests.
synoet
reviewed
Oct 10, 2021
| export default function SubmissionTest({tests}) { | ||
| const classes = useStyles(); | ||
|
|
||
| if (!tests) { |
synoet
reviewed
Oct 10, 2021
| return null; | ||
| } | ||
| return ( | ||
| <React.Fragment> |
synoet
reviewed
Oct 10, 2021
| } | ||
| return ( | ||
| <React.Fragment> | ||
| {tests.map((test, index) => ( |
There was a problem hiding this comment.
No need to map, there should only be one instance in here.
synoet
pushed a commit
that referenced
this pull request
Oct 30, 2021
wabscale
pushed a commit
that referenced
this pull request
Oct 31, 2021
wabscale
pushed a commit
that referenced
this pull request
Nov 1, 2021
wabscale
pushed a commit
that referenced
this pull request
Nov 2, 2021
Signed-off-by: John McCann Cunniff Jr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.