Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHG Assignment Card #256

Merged
merged 7 commits into from
Oct 18, 2021
Merged

Conversation

as14692
Copy link
Contributor

@as14692 as14692 commented Sep 27, 2021

This solves the issue 246

<Box className={classes.courseActionsContainer}>
<Button
onClick = {() => {
history.push(`/courses/assignments?courseId=${id}`);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace with history.push('/courses/assignment?assignmentId=${id}')

}) => {
const classes = useStyles();

let due_days = Math.round((new Date(due_date) - new Date())/(1000*3600*24));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use const not let

}) => {
const classes = useStyles();

let due_days = Math.round((new Date(due_date) - new Date())/(1000*3600*24));
due_days=9;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this line

<Box className={classes.courseActionsContainer}>
<Button
onClick = {() => {
history.push(`/courses/assignments/submissions?assignmentId=${id}`);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is still not it.
you need to be hitting /courses/assignment?addingmentId=${id}

@wabscale wabscale linked an issue Oct 1, 2021 that may be closed by this pull request
@wabscale wabscale added feature New feature or request frontend labels Oct 1, 2021
@synoet synoet merged commit 171922b into AnubisLMS:CHG-UI-REDESIGN Oct 18, 2021
synoet pushed a commit that referenced this pull request Oct 30, 2021
wabscale pushed a commit that referenced this pull request Oct 31, 2021
wabscale pushed a commit that referenced this pull request Nov 1, 2021
wabscale pushed a commit that referenced this pull request Nov 2, 2021
Signed-off-by: John McCann Cunniff Jr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CHG New Assignment Card Design
3 participants