Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

error-nil: support Empty and Zero error #153

Merged
merged 5 commits into from
Oct 3, 2024
Merged

error-nil: support Empty and Zero error #153

merged 5 commits into from
Oct 3, 2024

Conversation

mmorel-35
Copy link

@mmorel-35 mmorel-35 commented Jun 24, 2024 •
edited
Loading

This is a partial fix for #138

It doesn't fix this situations

assert.Empty(t, errs)
assert.Empty(t, err.String())

@coveralls
Copy link

coveralls commented Jun 24, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9642153348

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.664%
Totals Coverage Status
Change from base Build 9608177733: 0.0%
Covered Lines: 2173
Relevant Lines: 2320
💛 - Coveralls

@mmorel-35 mmorel-35 changed the title error-nil: support empty and notempty error error-nil: support empty and zero error Jun 24, 2024
ccoVeille
ccoVeille reviewed Jun 24, 2024
View reviewed changes
Copy link
Contributor

@ccoVeille ccoVeille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unsure if it's normal you used err.String in Ignored.

We need to discuss with Anton about it

@coveralls
Copy link

coveralls commented Jun 26, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9673215979

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.692%
Totals Coverage Status
Change from base Build 9673069496: 0.0%
Covered Lines: 2213
Relevant Lines: 2362
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 4, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9798872885

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.692%
Totals Coverage Status
Change from base Build 9743211634: 0.0%
Covered Lines: 2213
Relevant Lines: 2362
💛 - Coveralls

@coveralls
Copy link

coveralls commented Aug 29, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11168036466

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.805%
Totals Coverage Status
Change from base Build 11167713294: 0.0%
Covered Lines: 2453
Relevant Lines: 2615
💛 - Coveralls

@Antonboom Antonboom changed the title error-nil: support empty and zero error error-nil: support Empty and Zero error Oct 3, 2024
@Antonboom Antonboom merged commit ea890b3 into Antonboom:master Oct 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antonboom Antonboom Antonboom left review comments

@ccoVeille ccoVeille ccoVeille left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mmorel-35 @coveralls @ccoVeille @Antonboom