1.20.4 #325
1.20.4 #325
Conversation
| loader_version=0.14.24 | ||
| minecraft_version=1.20.4 | ||
| yarn_version=1.20.4+build.3 | ||
| loader_version=0.15.2 |
There was a problem hiding this comment.
Not sure what the "correct" loader version to use is, I went with the same version meteor-client is using https://github.com/MeteorDevelopment/meteor-client/blob/master/gradle.properties#L6
| e.printStackTrace(); | ||
| } | ||
| return null; | ||
| } | ||
|
|
||
| @Override |
There was a problem hiding this comment.
This has changed pretty significantly, but as far as I could tell, the old code was a copy-paste of the base class implementation with the TextureUrlChecker.isAllowedTextureDomain() check removed, and checking the signature against publicKey instead of servicesKeySet from the base class. I made the same changes when overriding the 1.20.4 method, but haven't tested it.
| } else { | ||
| status += (String.format(" (%s)", StatusEffectUtil.getDurationText(instance, 1))); | ||
| status += (String.format(" (%s)", StatusEffectUtil.getDurationText(instance, 1, 20))); |
There was a problem hiding this comment.
Probably safe to assume 20 unless we want this to scale on tick warped servers for whatever reason
There was a problem hiding this comment.
I think its safer to use TickRate.INSTANCE.getTickRate(), some servers may run with <20 tps.
Description
Update for 1.20.4
Related Issue
#310
Motivation and Context
AutoFarm crashes on 1.20.4 when using the 1.20.2 build
How Has This Been Tested?
Built it, loaded it, AutoFarm works great now and I haven't noticed any other crashes. Haven't tested anything else
Types of changes