-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ANT-1890] Properly handle playlist_reset in generaldata.ini #879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonMarechal25
changed the title
[ANT-1890]
[ANT-1890] Properly handle playlist_reset in general_data.ini
Jul 19, 2024
a-zakir
previously approved these changes
Jul 22, 2024
flomnes
changed the title
[ANT-1890] Properly handle playlist_reset in general_data.ini
[ANT-1890] Properly handle playlist_reset in generaldata.ini
Jul 22, 2024
flomnes
reviewed
Jul 22, 2024
Co-authored-by: Florian Omnès <[email protected]>
Co-authored-by: Florian Omnès <[email protected]>
Quality Gate passedIssues Measures |
flomnes
approved these changes
Jul 22, 2024
JasonMarechal25
added a commit
that referenced
this pull request
Jul 23, 2024
Fix #864 Properly handle data and avoid exception thrown when reading not numerical values with stoi when reading "playlist_reset" entry in general_data.ini --------- Co-authored-by: Florian Omnès <[email protected]> (cherry picked from commit caf2805)
JasonMarechal25
added a commit
that referenced
this pull request
Jul 23, 2024
Fix #864 Properly handle data and avoid exception thrown when reading not numerical values with stoi when reading "playlist_reset" entry in general_data.ini --------- Co-authored-by: Florian Omnès <[email protected]> (cherry picked from commit caf2805)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #864
Properly handle data and avoid exception thrown when reading not numerical values with stoi when reading "playlist_reset" entry in general_data.ini