Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use vcpkg for dependency management on all platforms #770

Merged
merged 79 commits into from
Mar 25, 2024
Merged

Use vcpkg for dependency management on all platforms #770

merged 79 commits into from
Mar 25, 2024

Conversation

JasonMarechal25
Copy link
Contributor

@JasonMarechal25 JasonMarechal25 commented Mar 5, 2024 •
edited
Loading

  • Change centos7 image management. Image is now antaresrte/xpansion-centos7 and tags follow semver schema
  • Migrate depedency management to vcpkg
  • Use action to setup cmake as much as possible
  • jsoncpp staticly linked to ease deploiment

Comments and explanations:

  • git fetch --unshallow is necessary because action checkout is shallow but vcpkg requires a "full" clone.
  • tbb is still manage manualy
  • jsoncpp is still link dynamicaly for MSVC due to difficulty to manage static/synamique with MSVC

@JasonMarechal25 JasonMarechal25 changed the title VCPKG Use vcpkg for dependency management Mar 15, 2024
@JasonMarechal25 JasonMarechal25 changed the title Use vcpkg for dependency management Use vcpkg for dependency management on all platforms Mar 15, 2024
@JasonMarechal25 JasonMarechal25 requested review from a-zakir, payetvin, guilpier-code and a team and removed request for a-zakir, guilpier-code and payetvin March 15, 2024 10:36
@JasonMarechal25 JasonMarechal25 marked this pull request as ready for review March 18, 2024 09:24
@JasonMarechal25 JasonMarechal25 requested a review from a-zakir March 22, 2024 14:27
@JasonMarechal25 JasonMarechal25 merged commit 245cb90 into develop Mar 25, 2024
7 of 8 checks passed
@JasonMarechal25 JasonMarechal25 deleted the feature/json_cpp branch March 25, 2024 13:59
JasonMarechal25 added a commit that referenced this pull request Apr 24, 2024
@JasonMarechal25
Use vcpkg for dependency management on all platforms (#770)
b8e0396 
- Change centos7 image management. Image is now
antaresrte/xpansion-centos7 and tags follow semver schema
- Migrate depedency management to vcpkg
- Use action to setup cmake as much as possible
- jsoncpp staticly linked to ease deploiment

Comments and explanations:

- _git fetch --unshallow_ is necessary because action checkout is
shallow but vcpkg requires a "full" clone.
- tbb is still manage manualy
- jsoncpp is still link dynamicaly for MSVC due to difficulty to manage
static/synamique with MSVC
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-zakir a-zakir a-zakir approved these changes

Assignees
No one assigned
Labels
size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JasonMarechal25 @a-zakir