Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pmax contribution #1827

Merged
merged 4 commits into from
Dec 18, 2023
Merged

Fix pmax contribution #1827

merged 4 commits into from
Dec 18, 2023

Conversation

a-zakir
Copy link
Contributor

@a-zakir a-zakir commented Dec 18, 2023

No description provided.

@watermelon-copilot-for-code-review Watermelon - Copilot For Code Review
Copy link

watermelon-copilot-for-code-review bot commented Dec 18, 2023 •
edited
Loading

Watermelon AI Summary

AI Summary deactivated by a-zakir

GitHub PRs

Antares_Simulator is an open repo and Watermelon will serve it for free.
🍉🫶

flomnes
flomnes approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@flomnes flomnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I proposed the same fix after investigating for about 1h30min ! Revert YAML and we can merge

@flomnes flomnes mentioned this pull request Dec 18, 2023
Closed
@flomnes flomnes merged commit cbb77b9 into develop Dec 18, 2023
4 checks passed
@flomnes flomnes deleted the fix/Pmax-contribution branch December 18, 2023 15:12
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flomnes flomnes flomnes approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@a-zakir @flomnes