fix detection of PyCharm console as TTY #89
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 5, 2021
|
This is an nbdev project, so edits need to be done directly in the notebooks. I've fixed that in master now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running fastprogress in PyCharm (both as part of a script as well as in the interactive Python console), fastprogress does not output a progress bar:
(same behavior as e.g. in #62)
This is because
sys.stdout.isatty()returnsFalsewithin PyCharm, and therefore the check inprintingfails: https://github.com/fastai/fastprogress/blob/67d40725e0225de51c0dc43255fd78681c014eb8/fastprogress/fastprogress.py#L214This PR adds an additional check for the
PYCHARM_HOSTEDenvironment variable to find out when fastprogress is run within PyCharm.An alternative would be to set the "Emulate terminal in output console" option in PyCharm, however this only seems to apply to run configurations, not to the interactive Python console.