Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TextEmbed incompatible with Urwid 2.5.3 #1

Closed
danschwarz opened this issue Feb 15, 2024 · 2 comments · Fixed by #2
Closed

TextEmbed incompatible with Urwid 2.5.3 #1

danschwarz opened this issue Feb 15, 2024 · 2 comments · Fixed by #2
Assignees
@AnonymouX47
Labels
bug Something isn't working

Comments

@danschwarz
Copy link

danschwarz commented Feb 15, 2024 •
edited
Loading

Description
See issue in Urwid

urwid/urwid#802
AnonymouX47 added a commit that referenced this issue Feb 16, 2024
@AnonymouX47
fix:TextEmbed: Fix widget placeholders
387b9b7 
- Fix: Use U+F8FE and U+F8FF (last two codepoints of first PUA) with
  widths of 1 cell instead of U+0000 and U+0001 with widths of 0 cells.
- Add: `._UW_PLACEHOLDER_HEAD` and `._UW_PLACEHOLDER_TAIL`.
- Change: Remove codepoints used for widget placeholders from
  `.get_text()`'s docstring.

Fixes incompatibility with urwid>=2.5.3.

Refs: #1
@AnonymouX47 AnonymouX47 added the bug Something isn't working label Feb 16, 2024
@AnonymouX47 AnonymouX47 mentioned this issue Feb 16, 2024
Merged
@AnonymouX47
Copy link
Owner

TextEmbed should work as good as before now. Alongside the fix, I added the ability to override the codepoints used for widget placeholders.

I just want to include a couple more updates and release at once.

Thanks.

@AnonymouX47
Copy link
Owner

AnonymouX47 commented Feb 17, 2024 •
edited
Loading

Released v0.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AnonymouX47 AnonymouX47

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix TextEmbed widget placeholders AnonymouX47/urwidgets
2 participants
@danschwarz @AnonymouX47