The Timeline resource is not saved when playing project

[Crystalwarrior]

OS

Occurred on Windows 10 x64 and Windows 11

Godot Version

3.4.stable

Plugin Version

1.2.1 (lastest)

Issue description

If you press the "play project" or "play scene" buttons when editing the timeline without pressing Ctrl+S beforehand, that timeline resource will break for the rest of the editor session without telling you. It will appear as if the timeline is saved properly, but in-game tests indicate that is not the case. When reloading the project, it will be revealed that none of your changes actually saved.

It's a horrendously frustrating bug that should be fixed ASAP, it could be godot-related but regardless it must have something to do with the debug instance locking up the resources and perhaps the timeline resource does not save fast enough or something. Whatever it is it's utterly wack.

Steps to reproduce

1. Create a timeline
2. Edit the timeline without saving via Ctrl+S
3. Launch your game.
4. Realize your in-game timeline does not match your most recent edits.
5. Restart the editor
6. Open the timeline
7. Realize your timeline did not save, despite lying to you saying it did.

Workaround

Make a habit to Ctrl+S every time you edit the timeline for anything. Otherwise get used to reloading your project after every change :/

[MdSahil-oss]

hey! you still need help in resolving this bug

[Crystalwarrior]

Here's the bug in action, the timeline resource is not modified even though the editor claims it is. I have it open in visual studio code and I edit it and it works.

Odvtm6LPrz.mp4

[AnidemDex]

I think maybe something related to save_external_data but I'm not sure if it's a good idea to force it to save, verify if it's saved or simply remove that function. I'll keep debugging

[AnidemDex]

Related to Zylann/godot_heightmap_plugin#101 (for future reference)

[Crystalwarrior]

Big problem, if you save a timeline that is like this, the save will not be recognized and you have to save at the "original" timeline (e.g. 1_present.tres)
So sub-resources require their main resource to be saved to update:

[AnidemDex]

Seems like #44 solves it. If this can't be replicated anymore on main, I'll close the issue

[AnidemDex]

Can't replicate in 1.4.3