Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify CMake #169

Merged
merged 5 commits into from
Aug 24, 2022
Merged

Simplify CMake #169

merged 5 commits into from
Aug 24, 2022

Conversation

lederernc
Copy link
Contributor

Simplify the CMakefile.txt to make it easier to maintain. Remove visual studio solution files as they are not necessary and hard to maintain properly.

I also converted the library to build as a static library. This is because the DLL being generated on windows was not exporting symbols properly. I can add proper support for shared vs static building in a later pull request.

I added compiler flags to Visual Studio builds to match the warnings as errors flags on non-VS builds.

@AngusJohnson AngusJohnson merged commit 74e73fa into AngusJohnson:main Aug 24, 2022
@AngusJohnson
Copy link
Owner

AngusJohnson commented Aug 24, 2022

Thanks Nicolas.
I've merged your changes which look just fine.
Howevr, I'm a complete novice with CMake so there's an element of trust there 😁😱🤞🙏.
And on that note, how do I get CMake to generate solution files so that Visual Studio will compile and execute the examples.
I'm sure there are online examples re using CMake in VS but I'm hoping you can provide a "quick and dirty" explanation that's specific to your modified CMakeLists.txt. I've gotten as far as

option(CLIPPER2_UTILS "Build utilities" ON)
option(CLIPPER2_EXAMPLES "Build examples" ON)
option(CLIPPER2_TESTS "Build tests" ON)

but no further. Cheers.

ps: I'm very likely going to need a reasonably thorough explanation, at least one that I can add to the documentation.
(I suspect there will be many Visual Studion users that are equally ignorant WRT CMake files.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants