-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Offset produces incorrect result #715
Comments
Replace - Clipper2/CPP/Clipper2Lib/src/clipper.offset.cpp Lines 579 to 582 in 466efe7
with -
|
@AngusJohnson yes, that helps. Thank you! |
It's still not quite right (ie it still needs tweaking), but this shouldn't be problematic as it is now. |
AngusJohnson
added a commit
that referenced
this issue
Nov 19, 2023
AngusJohnson
added a commit
that referenced
this issue
Nov 26, 2023
Changes since ver 1.2.3 include: 1. Important: Offsetting open path behaviour has changed. The delta now behaves as it did in Clipper1 (See Issue #707) 2. Important: Data structures of exported values in clipper.export.h have changed. 3. Minor bugfixes to PolyTree nesting (#679, #687) 4. Numerous minor bugfixes to polygon offsetting (#703, #715, #724) 5. Fixed an obscure bug in polygon clipping caused by horizontal spikes (#720) 6. Significantly improved documentation.
jiajuncccc
added a commit
to jiajuncccc/Clipper2
that referenced
this issue
Dec 15, 2023
* remotes/origin/main: Minor code tidy Added CLIPPER2_HI_PRECISION option in CMakeLists.txt Additional minor tweaks to cpp/benchmark tests Make googletest not be a git submodule, and instead clone it separately in the CI script (AngusJohnson#745) fix compiler warning of -Wunused-but-set-parameter with -fno-exceptions (AngusJohnson#744) Additional tweaks to GetIntersectPtBenchmark.cpp Additional GetIntersectPtBenchmark tweaks Fixed incorrect code comment Added new GetIntersectPoint benchmark test Updated other benchmark tests. Code formatting only (removed trailing spaces) Fixed minor typecasting issues (AngusJohnson#727) More tweaks to PointInPolygon benchmarking. Allow using external gtest with GTest:: qualified names (AngusJohnson#737) Fixed a significant (though uncommon) bug in polygon clipping (AngusJohnson#736) Fixed bugs in PointInPolygon benchmark testing. Minor tweaks to PointInPolygon benchmark testing. Fixed a minor syntax error tripping some C++ compilers Version 1.3.0 1. Fixed a significant offsetting bug introduced in previous update (AngusJohnson#733) 2. Fixed a C++ compile error when 32bit compiling (AngusJohnson#727) 3. Minor tweak to CMakeLists.txt (C++) (AngusJohnson#728) 4. Will now offset 'flat' polygons (Disc.AngusJohnson#725) 5. Reminder: recent change in open path offsetting behaviour (AngusJohnson#707) 6. Reminder: recent changes to clipper.export.h data structures. Fixed a typo and tweaked documentation Version 1.2.4 Changes since ver 1.2.3 include: 1. Important: Offsetting open path behaviour has changed. The delta now behaves as it did in Clipper1 (See Issue AngusJohnson#707) 2. Important: Data structures of exported values in clipper.export.h have changed. 3. Minor bugfixes to PolyTree nesting (AngusJohnson#679, AngusJohnson#687) 4. Numerous minor bugfixes to polygon offsetting (AngusJohnson#703, AngusJohnson#715, AngusJohnson#724) 5. Fixed an obscure bug in polygon clipping caused by horizontal spikes (AngusJohnson#720) 6. Significantly improved documentation. Additional minor bugfix to ClipperOffset (AngusJohnson#724 & Disc.AngusJohnson#726)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi, I was trying to update Clipper2 version from revision f9a40f0 to the current head and I see a regression in closed curve offset.
Somehow it misses this small circle in the new result, while it was producing correct result at the revision f9a40f0
Testcase (Please add this to your testcases if you fix this problem):
Two curves in the input, it is one body with hole. With negative offset outer body should become smaller, its hole should become bigger. The issue is that its hole completely disappears now.
The text was updated successfully, but these errors were encountered: