Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some missing units needed in DelphiBenchmark example #406

Closed
rs0xFFFF opened this issue Feb 10, 2023 · 5 comments
Closed

Some missing units needed in DelphiBenchmark example #406

rs0xFFFF opened this issue Feb 10, 2023 · 5 comments

Comments

@rs0xFFFF
Copy link 

program DelphiBenchmark;

{$APPTYPE CONSOLE}
{$R *.res}

uses
  Windows,
  ShellAPI,
  SysUtils,
  Classes,
  Clipper.SVG in '..\Utils\Clipper.SVG.pas',
  ClipMisc in '..\Utils\ClipMisc.pas',
  Timer in '..\Utils\Timer.pas',
  Clipper.Core in '..\Clipper2Lib\Clipper.Core.pas',
  Clipper.Engine in '..\Clipper2Lib\Clipper.Engine.pas',
  Clipper.Minkowski in '..\Clipper2Lib\Clipper.Minkowski.pas',
  Clipper.Offset in '..\Clipper2Lib\Clipper.Offset.pas',
  Clipper in '..\Clipper2Lib\Clipper.pas',
  Clipper.RectClip in '..\Clipper2Lib\Clipper.RectClip.pas';
AngusJohnson added a commit that referenced this issue Feb 11, 2023
@AngusJohnson
Finally added C# translation of recent RectClip update.
45ef43b 
(Updated RectClip documentation still pending.)
Minor tweak to DelphiBenchmark example (#406)
Minor tweaks to offsetting (so hope I haven't broken anything)
@AngusJohnson
Copy link
Owner

Hopefully fixed now.

@rs0xFFFF
Copy link
Author

Unfortunately does not compile. RectClip, Offset and Minkowski are missing.

@AngusJohnson
Copy link
Owner

OK, I'll check and fix. But I'm surprised, since none of these units are being benchmarked.

@AngusJohnson AngusJohnson reopened this Feb 12, 2023
@rs0xFFFF
Copy link
Author

rs0xFFFF commented Feb 12, 2023 •
edited
Loading

These units are pulled in by e.g. clipper.pas
You probably don't notice the error because the unit paths come in via the PATH variable?

AngusJohnson added a commit that referenced this issue Feb 16, 2023
@AngusJohnson
Fixed several offsetting bugs (#407, #408)
49eff0f 
Fixed multiple bugs in RectClip and RectClipLines (#410)
Fixed null warnings in C# code (#414)
Fixed missing units in DelphiBenchmark example (#406)
@AngusJohnson
Copy link
Owner

Hopefully (finally) fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AngusJohnson @rs0xFFFF