Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delphi 7 and FPC compatibility #402

Closed
rs0xFFFF opened this issue Feb 8, 2023 · 3 comments
Closed

Delphi 7 and FPC compatibility #402

rs0xFFFF opened this issue Feb 8, 2023 · 3 comments

Comments

@rs0xFFFF
Copy link

rs0xFFFF commented Feb 8, 2023

Please add

{$IF CompilerVersion <= 15} //Delphi 7
type
  TPointerList = array of Pointer;
  TListSortCompareFunc = function (Item1, Item2: Pointer): Integer;
{$IFEND}

to unit Clipper.Core for D7 compatibility. THX!

P.S.
The declaration of TPointerList in Delphi 2007 looks like this:

TPointerList = array[0..MaxListSize - 1] of Pointer;

while the one in Delphi 10.2 is this:

TPointerList = array of Pointer;

AngusJohnson added a commit that referenced this issue Feb 9, 2023
Fixed RectClipLines code (Delphi & C++)
Minor changes & code tidy in Clipper.Offset
Fixed Delphi 7 compatability issue (#402)
Fixed a very minor offset bug (#403)
@rs0xFFFF
Copy link
Author

rs0xFFFF commented Feb 9, 2023

Sorry, we have to dig deeper... That must be right above the class.

{$ifdef FPC}
  TPointerList = array of Pointer;
  TListSortCompareFunc = function (Item1, Item2: Pointer): Integer;
{$else}
{$if CompilerVersion < 23} //prior Delphi XE2
  TPointerList = array of Pointer;
  TListSortCompareFunc = function (Item1, Item2: Pointer): Integer;
{$ifend}
{$endif}

  TListEx = class
  private

@rs0xFFFF rs0xFFFF changed the title Delphi 7 compatibility Delphi 7 and FPC compatibility Feb 9, 2023
AngusJohnson added a commit that referenced this issue Feb 10, 2023
Fixed Delphi 7 and FPC compatibility (#402)
@AngusJohnson
Copy link
Owner

Hopefully finally fixed now 🤞🙏.

@rs0xFFFF
Copy link
Author

Everything runs like clockwork again. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants