Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Umbraco 11 #8

Merged
merged 1 commit into from
Dec 23, 2022
Merged

Conversation

rickbutterfield
Copy link
Contributor

The below error appears when trying to use this package with Umbraco 11:
image

System.MissingMethodException: Method not found: 'Void Umbraco.Extensions.ServiceCollectionExtensions.AddUnique(Microsoft.Extensions.DependencyInjection.IServiceCollection)'.
   at Our.Umbraco.PersonalisationGroups.Core.ServicesConfiguration.AddProviders(IServiceCollection services, IConfigurationSection configSection)
   at Our.Umbraco.PersonalisationGroups.Core.ServicesConfiguration.AddPersonalisationGroups(IUmbracoBuilder builder, IConfiguration config)

AddUnique requires both a TService and TImplementing in Umbraco 11, so I believe switching this to AddSingleton should resolve the issue?

@AndyButland
Copy link
Owner

Thanks @rickbutterfield - I had planned some time over the holidays to check this package worked OK on 11. Thanks for answering it for me and fixing it! Does look like this will work on 10 too so it'll just be a case of releasing a patch that'll then work on both versions.

@AndyButland AndyButland merged commit 5849ccf into AndyButland:main Dec 23, 2022
@AndyButland
Copy link
Owner

I've released 3.2.3 now with this update. Thanks again and Merry Christmas!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants