Prepare client to work with back-end api #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mik629
commented
Jun 15, 2021
mik629
commented
- added back-end DTOs
- added retrofit
- added repositories
- added corresponding domain models
- used kotlin serialization (haven't verified it yet, in hackathon app we used moshi)
* added back-end DTOs * added retrofit * added repositories * added corresponding domain models * used kotlin serialization (haven't verified it yet, in hackathon app we used moshi)
mik629
commented
Jun 15, 2021
|
|
||
| @GET("lectures/by-id") | ||
| suspend fun getLectureById( | ||
| @Query(value = "lectureId") lectureId: Long |
There was a problem hiding this comment.
Better to use a path variable, I think
mik629
commented
Jun 15, 2021
| @Body updateLectureRequestDTO: UpdateLectureRequestDTO | ||
| ) | ||
|
|
||
| @GET("lectures/all") |
There was a problem hiding this comment.
Better to use path variable, like:
{courseId}/lectures
mik629
commented
Jun 15, 2021
|
|
||
| // fixme: fix user auth | ||
| class TokenAuthenticator @Inject constructor( | ||
| // private val prefsStorage: PrefsStorage |
There was a problem hiding this comment.
Add a PrefsStorage having DataStore under the hood
mik629
commented
Jun 15, 2021
app/src/main/java/com/academy/android/domain/repositories/CourseRepository.kt
Show resolved
Hide resolved
* fixed broken gradlew * upgraded gradle to 7.2
* video cards are yet to be done * empty result handling is also to be done
* added video cards
* cleaned up unused resources
* renamed repositories to better readability
* renamed interactors package * renamed *Interactor -> *UseCase
* added username/password input fields * added "mentor" switch
* prepare for using auth via back-end
* handled wrong credentials
Re-writing UI in Compose
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.