Skip to content

Commit

Permalink
[PATCH] tridentfb: Fix scrolling artifacts during disk IO
Browse files Browse the repository at this point in the history
Reported by: Jochen Hein (Bugzilla Bug 4312)

When there is disk I/O happening, the framebuffer has a little snow on
the screen.  Once I/O has finished, no garbage remains on screen.

This bug was explained by: Knut Petersen

Most important is CRTC register 2f, signal quality is also improved for
higher vclk values by changing set_vclk() according to the X drivers and
cyblafb.c

The fix is to set the performance register (0x2f) with a more stable
value.

Signed-off-by: Antonino Daplas <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
adaplas authored and Linus Torvalds committed Aug 1, 2005
1 parent 8dad46c commit 8d894c4
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/video/tridentfb.c
Original file line number Diff line number Diff line change
Expand Up @@ -904,7 +904,7 @@ static int tridentfb_set_par(struct fb_info *info)
write3X4(DRAMControl, tmp); //both IO,linear enable

write3X4(InterfaceSel, read3X4(InterfaceSel) | 0x40);
write3X4(Performance,0x20);
write3X4(Performance,0x92);
write3X4(PCIReg,0x07); //MMIO & PCI read and write burst enable

/* convert from picoseconds to MHz */
Expand Down

0 comments on commit 8d894c4

Please sign in to comment.