Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS GWLB Support #95

Open
wants to merge 1 commit into
base: fck-nat-1.4
Choose a base branch
from

Conversation

ozcrn
Copy link

@ozcrn ozcrn commented Aug 12, 2024

Adds initial support for AWS Gateway Load Balancer integration utilising aws-gateway-load-balancer-tunnel-handler

Implements feature request #92

@ddouglas
Copy link

I get the idea behind this, but building this software in the same ami that is running in production feels wrong. This software should be compiled for this os and arch, hosted in Github Packages or S3, and then downloaded onto the box during fcknats ami build.

With the current way this is setup, all the build requirements are persisted to the final image. Additionally, there is no way to disable this functionality. If i as a consumer of fcknat don't want or need this feature, I still have to deal with it existing on the ec2 instance I deploy

@AndrewGuenther
Copy link
Owner

I agree with @ddouglas about the build deps, but we also don't have good support (yet) in our build process for building these dependencies elsewhere. We've got the same problem with NAT64 support. Given that we've got two use cases now, I'll work on cooking something up.

Overall, this is great and I'm excited to start testing it out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants